Enable asset store for Godot 3.0 #12778
Conversation
|
And why its printed ERROR in the description of each asset - its a subject of another issue, if I remove filter it loads 2.1 with that bug for each assets, my PR does nothing with it - it just enabled asset store and make it use 3.0 filter. Installation and searching worked as expected.. |
| @@ -867,6 +867,8 @@ void EditorAssetLibrary::_search(int p_page) { | |||
| } | |||
| args += String() + "sort=" + sort_key[sort->get_selected()]; | |||
|
|
|||
| args += "&godot_version=3.0"; | |||
There was a problem hiding this comment.
can we grab version number from somewhere, instead of hard code?
There was a problem hiding this comment.
I looking for possible solution...
| repository->add_item("godotengine.org"); | ||
| repository->set_item_metadata(0, "https://godotengine.org/asset-library/api"); | ||
| */ | ||
| repository->add_item("localhost"); | ||
| repository->set_item_metadata(/*1*/ 0, "http://127.0.0.1/asset-library/api"); |
There was a problem hiding this comment.
You should leave localhost, it is useful when testing the assetlib (also, uncomment the 1 there).
There was a problem hiding this comment.
Ah, you write uncommenting "1" ? Ok..
There was a problem hiding this comment.
It should not be commented out, it should be active, with id 1 instead of 0.
There was a problem hiding this comment.
repository->set_item_metadata(0, "https://godotengine.org/asset-library/api");
should also be 1 instead 0 ?
There was a problem hiding this comment.
It should be:
repository->add_item("godotengine.org");
repository->set_item_metadata(0, "https://godotengine.org/asset-library/api");
repository->add_item("localhost");
repository->set_item_metadata(1, "http://127.0.0.1/asset-library/api");
|
Ok, I squashed these commits into one |
| repository->add_item("localhost"); | ||
| repository->set_item_metadata(/*1*/ 0, "http://127.0.0.1/asset-library/api"); | ||
|
|
||
| /* reserved */ |
There was a problem hiding this comment.
Probably not needed, it doesn't say much and the scope of localhost is quite obvious by itself.
I enabled it and allow loads only 3.0 assets from site - This is simple fix in http request line, I wonder why nobody touches this...
fix for #7147