Add polygon 2d editor handle icons #13173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @djrm. Looks fine to me, but maybe the color variations should be modulate in code instead of different SVGs? |
djrm
reviewed
Nov 22, 2017
| <ellipse cx="5" cy="1047.4" rx="4" ry="4" fill="#fff"/> | ||
| <ellipse cx="5" cy="1047.4" rx="3" ry="3" fill="#8484ff"/> | ||
| </g> | ||
| </svg> |
There was a problem hiding this comment.
this can be definitely modulated. so no need to add this version
| <ellipse cx="5" cy="1047.4" rx="4" ry="4" fill="#fff"/> | ||
| <ellipse cx="5" cy="1047.4" rx="3" ry="3" fill="#84ff84"/> | ||
| </g> | ||
| </svg> |
There was a problem hiding this comment.
can you try with this icon
icon_editor_handle_add.zip
|
Bump :) |
|
Looks cool now:
|
ghost
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are needed for the polygon 2d editor and somehow got lost in e5de5b4.
EDIT Here's an overview why: