Fix unnecessary overbright modulates used in a few editors #93720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There may be a good reason for these colors to be like this, but I can't think of one. It does indeed feel out of place. |
|
It seems like this was first done in this PR: #13173 Gr0ud seems to have copied it for the tile editors. The GradientTexture2D one was from me and I confirm that my only reason is that I didn't know how color modulation works and I didn't want to recompile 10 times until it looked good, so I copied it from the abstract polygon editor. I noticed this quirk lately and it's haunted me since, hence making this PR. |
Mickeon
approved these changes
Jun 29, 2024
Mickeon
added
the
cherrypick:4.2
akien-mga
approved these changes
Jun 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the editor is modulated to dark before you quit, these handles would shine in weird colors.
This PR fixes that.