Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes build error on Linux after its introduction in #18949 #18967

Merged
merged 1 commit into from
May 17, 2018

Conversation

Valentactive
Copy link
Contributor

The function expects now a return value. Returning NULL seems to work in
this case (it is called by the C# part and compared against NULL there too, in case MSBbuild is not found.)

godotsharp_build_error

The function expects now a return value. Returning NULL seems to work in
this case.
@akien-mga akien-mga added this to the 3.1 milestone May 17, 2018
@akien-mga akien-mga merged commit edc3e6b into godotengine:master May 17, 2018
@neikeq
Copy link
Contributor

neikeq commented May 17, 2018

Damn, the PR was Windows focused so I forgot to test on Unix. Sorry about that :/

@Valentactive
Copy link
Contributor Author

I work on a project since few weeks and am doing almost every day at least once a build with mono support, that's why I see it :)

@Valentactive Valentactive deleted the fix-mono-build-linux branch May 19, 2018 20:26
@hpvb
Copy link
Member

hpvb commented Jun 1, 2018

Cherry picked into 3.0.3

@hpvb hpvb removed the cherrypick label Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants