-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mono: Project building fixes #18949
Merged
Merged
Mono: Project building fixes #18949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neikeq
commented
May 16, 2018
- Set (Csc/Vbc/Fsc)ToolExe environment variables to point to the batch files in Mono's bin directory when building with Mono's MSBuild. Thanks to @PJB3005 for finding this out, here I was trying to point it to the exe...
- Set Mono's MSBuild as the default build tool on Windows.
- Generate projects with portable DebugType instead of full.
- Set (Csc/Vbc/Fsc)ToolExe environment variables to point to the batch files in Mono's bin directory when building with Mono's MSBuild. - Set Mono's MSBuild as the default build tool on Windows. - Generate projects with portable DebugType instead of full.
Valentactive
added a commit
to Valentactive/godot
that referenced
this pull request
May 17, 2018
The function expects now a return value. Returning NULL seems to work in this case.
akien-mga
added a commit
that referenced
this pull request
May 17, 2018
fixes build error on Linux after its introduction in #18949
#18967 should be cherry-picked with/within this one. |
@neikeq what to do ?(windows 10) |
Cherry picked into 3.0.3 |
hpvb
pushed a commit
that referenced
this pull request
Jun 1, 2018
The function expects now a return value. Returning NULL seems to work in this case. (cherry picked from commit 6c74f3d)
malcolmhoward
pushed a commit
to malcolmhoward/godot
that referenced
this pull request
Jul 31, 2018
The function expects now a return value. Returning NULL seems to work in this case.
malcolmhoward
pushed a commit
to malcolmhoward/godot
that referenced
this pull request
Jul 31, 2018
The function expects now a return value. Returning NULL seems to work in this case. (cherry picked from commit 6c74f3d)
malcolmhoward
pushed a commit
to malcolmhoward/godot
that referenced
this pull request
Jul 31, 2018
The function expects now a return value. Returning NULL seems to work in this case.
malcolmhoward
pushed a commit
to malcolmhoward/godot
that referenced
this pull request
Jul 31, 2018
The function expects now a return value. Returning NULL seems to work in this case. (cherry picked from commit 6c74f3d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.