-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resurrect integrated error display for the Debugger. #21884
Conversation
166a231
to
13370e3
Compare
Nice, I am very happy you managed to rebase those changes. Thanks for your hard work! |
I guess this will be fixed too - #21676. Good job ! |
@Chaosus Absolutely. You may click on either the warning itself or the |
Thanks for the contribution, it looks great! We briefly discussed it on IRC and had some suggestions/concerns, but those can be worked on in follow-up PRs, namely:
|
this is very cool, but i noticed something odd: previously, if we scrolled all the way down on the scrollbar in the error log, any new errors that would show, would make the scroll bar go down to the bottom automatically. now, it just stays wherever you left the scrollbar at, and then now you need to scroll down to get to the last error message. |
This was removed by @RyanStein in godotengine#21884 in the case where an error message is provided, but this is actually useful information to have even when there is a custom error message. This PR makes it so that the "C++ Error" is shown whenever there is a custom error message provided. Also adds method name to the error item title, and re-adds the most relevant info in the tooltip for quick error checks without expanding. Renames C Error/Source to C++ Error/Source, since that's what it is. And fix untranslatable entry due to misuse of TTR(). And some more cleanup for readability. Cf. godotengine#32276 (comment)
This was removed by @RyanStein in godotengine#21884 in the case where an error message is provided, but this is actually useful information to have even when there is a custom error message. This PR makes it so that the "C++ Error" is shown whenever there is a custom error message provided. Also adds method name to the error item title, and re-adds the most relevant info in the tooltip for quick error checks without expanding. Renames C Error/Source to C++ Error/Source, since that's what it is. And fix untranslatable entry due to misuse of TTR(). And some more cleanup for readability. Cf. godotengine#32276 (comment)
I have taken a look at how the editor has changed since I originally made this feature(#15272) and found it simpler to just re-write on top of the changes made since. I was able to integrate the right-click error copy as well. No rebase should be necessary.
I made use of @akien-mga 's suggested changes from the branch indicated. We should finally be able to close #15234 and salvage this.
I would appreciate any feedback. Thank you.
Edit: Also fixes #21676