Allow Tweens with duration 0 and above

[DevinPentecost]

Hi,

This is the change that appears to work to resolve the following issue:
#29567

I've built it and confirmed that it works. However I do not know how to run unit tests to confirm it does not break anything else. Additionally, I'd like to add a unit test for this particular condition if possible to make sure it is not broken in the future.

If you could please direct me to how to ensure this fix does not break tests and how to add my own test to this pull request I'd appreciate it.

Thanks,
-Devin

[Calinou]

However I do not know how to run unit tests to confirm it does not break anything else. Additionally, I'd like to add a unit test for this particular condition if possible to make sure it is not broken in the future.

The short answer is that we don't add unit tests for new features; see discussion in #2641 🙂

There are a few built-in tests in place, but they don't function like traditional unit tests for the most part (they're mostly here to test engine features when porting Godot to a new platform).

[bojidar-bg]

There are 5 other instances of p_duration <= 0 in the same file. Shouldn't they be changed as well?

[DevinPentecost]

I think you're absolutely correct. For some reason my search didn't find them. Let me update later tonight (unless someone else wants to do that beforehand :) ) Thanks, -Devin

…

On Fri, Jun 7, 2019, 07:48 Bojidar Marinov ***@***.***> wrote: There are 5 other instances of p_duration <= 0 in the same file. Shouldn't they be changed as well? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#29568?email_source=notifications&email_token=AAG6RFDGBOPVFD6QZFMTHN3PZJYLPA5CNFSM4HVQLYEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXGBKMA#issuecomment-499914032>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG6RFD466BIGQEULQ7LBL3PZJYLPANCNFSM4HVQLYEA> .

[DevinPentecost]

I added a bunch of comments and did some light refactoring...
Hopefully I didn't break too much with it, I'll try to take a look later tonight to verify more

[DevinPentecost]

Fixed merge issue, waiting on builds...

[DevinPentecost]

Making a few more fixes, I'll keep working on them over the weekend

[DevinPentecost]

Hi,

I think I've done all I intend to do with this PR. Please review the changes.

Thanks!
-Devin

[Chaosus]

You need to squash commits together as described in http://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#mastering-the-pr-workflow-the-rebase Be careful if you didnt do it before (better test it on one of your local repositories)

[DevinPentecost]

Hi,

I'm working on squashing the commits. I may need to reopen the PR with a new branch.

Thanks,
-Devin