Add Min/Max Window Size Setting

[codecustard]

Add project settings to easily set the minimum and maximum window size.

Imitates Test Width/Height Setting, meaning you need to set both the width and the height, otherwise it does nothing. Is that intended behavior?

Closes: #31303

[akien-mga]

Imitates Test Width/Height Setting, meaning you need to set both the width and the height, otherwise it does nothing. Is that intended behavior?

I don't have a strong opinion for the existing Test Width/Height, but for the min/max window size they don't have to be coupled, you can set only a min or only a max depending on your game's needs.

[Calinou]

Imitates Test Width/Height Setting, meaning you need to set both the width and the height, otherwise it does nothing. Is that intended behavior?

It would make sense if you could limit only the width or height, so I'd say it should work even if one of the dimensions is equal to 0. This is especially true if no error message is printed when invalid settings are supplied 🙂

[akien-mga]

It would make sense if you could limit only the width or height, so I'd say it should work even if one of the dimensions is equal to 0. This is especially true if no error message is printed when invalid settings are supplied.

Makes sense to change it indeed. I don't see a use case for not applying either test width or height if one is not supplied.

[akien-mga]

Thanks!

It would make sense if you could limit only the width or height, so I'd say it should work even if one of the dimensions is equal to 0. This is especially true if no error message is printed when invalid settings are supplied.

Note that this isn't done in this PR, so it would have to be changed in a new PR.

[akien-mga]

It crashes on X11 when you start a project:

[1] /lib64/libc.so.6(+0x3caf0) [0x7f5966679af0] (??:0)
[2] /lib64/libX11.so.6(XChangeProperty+0x20) [0x7f5966cbc500] (??:0)
[3] /lib64/libX11.so.6(XSetWMSizeHints+0x10f) [0x7f5966cd942f] (??:0)
[4] OS_X11::set_min_window_size(Vector2) (/home/akien/Projects/godot/godot.git/platform/x11/os_x11.cpp:1289)
[5] Main::setup(char const*, int, char**, bool) (/home/akien/Projects/godot/godot.git/main/main.cpp:942 (discriminator 3))
[6] /home/akien/Projects/godot/godot.git/bin/godot.x11.tools.64(main+0xcd) [0x13e8a3f] (/home/akien/Projects/godot/godot.git/platform/x11/godot_x11.cpp:49 (discriminator 2))
[7] /lib64/libc.so.6(__libc_start_main+0xeb) [0x7f5966663b0b] (??:0)
[8] /home/akien/Projects/godot/godot.git/bin/godot.x11.tools.64(_start+0x2a) [0x13e88ca] (/home/iurt/rpmbuild/BUILD/glibc-2.29/csu/../sysdeps/x86_64/start.S:122)
-- END OF BACKTRACE --

[akien-mga]

After reverting this PR, calling OS.set_min_window_size() from script seems to work fine, so the problem seem to be that this PR calls it too early before OS is ready to take such VM-specific calls. It would likely have to be passed the the video mode like other window settings.

[akien-mga]

Reverted by #31435 for now until a better approach can be implemented.

[bruvzg]

so the problem seem to be that this PR calls it too early before OS

It should be called in setup2, after the OS::get_singleton()->initialize call, which is responsible for creation of the main window.

[bruvzg]

It would make sense if you could limit only the width or height, so I'd say it should work even if one of the dimensions is equal to 0.

This should be quite easy to implement with just a few extra checks.