Fix "Make Scene Root" deleting previous root whenever focusing another scene #32412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r scene Hopefully fixes godotengine#24484 and fixes godotengine#27222.
bojidar-bg
commented
Sep 28, 2019
| _node_replace_owner(root, root, root, MODE_UNDO); | ||
|
|
||
| editor_data->get_undo_redo().add_do_method(scene_tree, "update_tree"); | ||
| editor_data->get_undo_redo().add_undo_method(scene_tree, "update_tree"); | ||
| editor_data->get_undo_redo().add_undo_reference(root); |
There was a problem hiding this comment.
This line was the main culprit: the other are mostly stylistic/correctness changes.
add_undo_reference adds a reference which should persist as long as the undo history does. Unfortunately, the root node is preserved, not scrapped, so it actually "outlives" the undo history.
A cool side effect of this was that doing "Make Scene Root" twice, once on a node and then again on the old root node, followed by changing the scene would crash the editor.
|
Thanks! |
|
Cherry-picked for 3.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #24484 and fixes #27222.