Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 3D camera gizmo icon #35784

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jan 31, 2020

master version of #49644.

The gizmo icon obstructed the line-based camera gizmo, which made it difficult to see the actual camera orientation.

This also removes the unused SpatialStreamPlayer gizmo icon.

This closes godotengine/godot-proposals#425.

Preview

Before

Hidden

After

Not hidden

The gizmo icon obstructed the line-based camera gizmo, which made it
difficult to see the actual camera orientation.

This also removes the unused SpatialStreamPlayer gizmo icon.

This closes godotengine/godot-proposals#425.
@Zireael07
Copy link
Contributor

I don't think it's a move in the right direction. The gizmo should rotate to show the correct direction and/or have a direction arrow added. The pink camera extents gizmo can get very small for small fov cameras and/or zoomed out view.

@Calinou
Copy link
Member Author

Calinou commented Jan 31, 2020

@Zireael07 The gizmo icon can't be made to rotate in all situations. For instance, if you're right in front or behind the camera, it would spazz out in various directions.

It can be done when you look at the camera from other directions, but it might not be trivial.

We could perhaps add a solid box to complement the pink gizmo as proposed in godotengine/godot-proposals#425, but I'd rather not see a complex model added just for this.

@aaronfranke
Copy link
Member

What about if the gizmo icon behaved like a two-sided Sprite3D?

@akien-mga akien-mga added this to the 4.0 milestone Feb 10, 2020
@akien-mga akien-mga requested a review from JFonS February 10, 2020 09:49
@akien-mga
Copy link
Member

I'm also slightly concerned about readability, we might end up with situations where the camera is hard to locate.

But I agree that removing the billboarded icon is good, further improvements should be made on the 3D gizmo itself to make it more readable (e.g. changing scale, colors, or adding a triangle showing the up direction as done in Blender).

@akien-mga akien-mga merged commit 880a8fc into godotengine:master Feb 19, 2020
@akien-mga
Copy link
Member

Thanks!

@Calinou
Copy link
Member Author

Calinou commented Feb 19, 2020

adding a triangle showing the up direction as done in Blender).

There's already one (you can see it on the screenshot), but maybe it needs to be drawn differently to be easier to notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement camera icon as 3D model facing the correct direction
5 participants