Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement camera icon as 3D model facing the correct direction #425

Closed
Sakari369 opened this issue Jan 31, 2020 · 4 comments · Fixed by godotengine/godot#35784
Closed

Implement camera icon as 3D model facing the correct direction #425

Sakari369 opened this issue Jan 31, 2020 · 4 comments · Fixed by godotengine/godot#35784
Milestone

Comments

@Sakari369
Copy link

Sakari369 commented Jan 31, 2020

Describe the project you are working on:
Any project.

Describe the problem or limitation you are having in your project:
When zooming the scene far away,and looking at the camera in the scene, it can be confusing to think that the camera icon is showing which way the camera is looking at in the scene.

For example, here looking at the camera from far away where the camera detail is not shown, I see this, and might think that the camera is facing outwards from the center of the scene:

image

Now when I zoom in on the scene, actually the camera is facing the other way

image

I notice myself being constantly confused by this fact that the icon is facing whatever direction that is not related to the actual camera looking at direction in 3D space.

Describe how this feature / enhancement will help you overcome this problem or limitation:

Would suggest implementing the camera icon as an actual 3D model of a camera, that is always facing in the correct orientation. Would help to see better anyway where the model is looking at.

Or possibly replacing the icon with a direction neutral one.

*Show a mock up screenshots/video or a flow diagram explaining how your proposal will work:

Unreal engine seems to do this already:

image

Or as an easier solution, use a direction neutral camera icon like this:

image

Describe implementation detail for your proposal (in code), if possible:
Figure out a 3D model for the camera, replace the icon with this 3D model.

If this enhancement will not be used often, can it be worked around with a few lines of script?:
Dont think so.

Is there a reason why this should be core and not an add-on in the asset library?:

Part of the core mechanics. Would make it more user friendly.

@Sakari369 Sakari369 changed the title Flip camera icon horizontally to face the direction in the scene where the camera is looking at, or replace with direction neutral camera icon. Implement camera icon as 3D model facing the correct direction Jan 31, 2020
@Calinou
Copy link
Member

Calinou commented Jan 31, 2020

We can remove the camera billboard sprite entirely and maybe enlarge the purple gizmo we currently have. This is a very simple solution to the problem described here. What do you think?

Calinou added a commit to Calinou/godot that referenced this issue Jan 31, 2020
The gizmo icon obstructed the line-based camera gizmo, which made it
difficult to see the actual camera orientation.

This also removes the unused SpatialStreamPlayer gizmo icon.

This closes godotengine/godot-proposals#425.
@Sakari369
Copy link
Author

Sakari369 commented Feb 5, 2020

We can remove the camera billboard sprite entirely and maybe enlarge the purple gizmo we currently have. This is a very simple solution to the problem described here. What do you think?

I would say this is a good simple solution, if it works in all ranges well, and can be made visible in all cases. Having a 3D model would help in cases of course where the fov or range of the camera is very small and the visual representation of that could get lost because of the small values.

Thanks for thinking about this!

@Tanza3D
Copy link

Tanza3D commented Sep 14, 2023

image
how about something similar to what blender has?

@Calinou
Copy link
Member

Calinou commented Sep 14, 2023

@Tanza3D This was addressed recently in 4.2.dev by readding the camera gizmo icon and keeping the lines.

There's already a triangle at the top of the Camera3D gizmo lines, but it's an outline instead of being solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants