Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing modal_closed signal #37557

Closed
wants to merge 1 commit into from

Conversation

qarmin
Copy link
Contributor

@qarmin qarmin commented Apr 3, 2020

Fixes error

 In Object of type 'PopupPanel': Attempt to connect nonexistent signal 'modal_closed' to callable 'ColorPickerButton::_modal_closed'.

@akien-mga
Copy link
Member

That's the wrong fix, nothing emits modal closed:

$ rg '"modal_closed"'
scene/gui/color_picker.cpp
997:            popup->connect("modal_closed", callable_mp(this, &ColorPickerButton::_modal_closed));

@akien-mga akien-mga added this to the 4.0 milestone Apr 7, 2020
@qarmin
Copy link
Contributor Author

qarmin commented Apr 7, 2020

Maybe here should be placed emit_signal(based on comment)

//modal_closed signal
void EditorSpinSlider::_value_input_closed() {
_evaluate_input_text();
value_input_just_closed = true;
}

@akien-mga
Copy link
Member

akien-mga commented Apr 7, 2020

I'm pretty sure modal_closed was removed on purpose by @reduz since there are no more modal dialogs but everything is Window.

That comment means that this used to be the callback for the modal_closed signal, not its emitter.

@qarmin
Copy link
Contributor Author

qarmin commented Jul 23, 2020

Closing since I have no idea how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants