Reimplement MenuButton::switch_on_hover #37771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermefelipecgs
force-pushed
the
reimplement_menu_switch_on_hover
branch
from
66895dc
to
16a7cca
Compare
60 tasks
guilhermefelipecgs
force-pushed
the
reimplement_menu_switch_on_hover
branch
3 times, most recently
from
d77f99e
to
612298b
Compare
guilhermefelipecgs
force-pushed
the
reimplement_menu_switch_on_hover
branch
from
612298b
to
13f1e4f
Compare
HaSa1002
added a commit
to HaSa1002/godot
that referenced
this pull request
May 29, 2020
Fixes that the Popups no longer steal focus, when they are popuped. Since the previous window no longer loses focus the popup has to emulate it. Therefor the behaviour in the PopupMenu was moved into the Popup itself. This commit provides the general structure for the implementation, but only the the Windows Display Server is implemented. Partial fix of godotengine#37531 along with godotengine#37771
|
@YeldhamDev Do you think this is still relevant after your last two related PRs, #50619 and #50904? |
|
Nope, not at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix partially #37531. We still have some focus problems.