Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary check for zero determinant in Basis::orthonormalize(). #37877

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Remove unnecessary check for zero determinant in Basis::orthonormalize(). #37877

merged 1 commit into from
Apr 14, 2020

Conversation

madmiraal
Copy link
Contributor

Basis::orthonormalize() doesn't require the determinant to be non-zero; so this check is unnecessary here.

Fixes #14864.

@akien-mga akien-mga added this to the 4.0 milestone Apr 14, 2020
@akien-mga akien-mga requested a review from reduz April 14, 2020 16:34
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 14, 2020
@akien-mga akien-mga merged commit 1d8a9a9 into godotengine:master Apr 14, 2020
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the fix-14864 branch April 14, 2020 17:50
@akien-mga
Copy link
Member

Cherry-picked for 3.2.2.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reduz reduz Awaiting requested review from reduz

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

ERROR: Basis::orthonormalize: Condition ' determinant() == 0 ' is true.
2 participants
@madmiraal @akien-mga