Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly use fallback for default fonts #40107

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Correctly use fallback for default fonts #40107

merged 1 commit into from
Jul 4, 2020

Conversation

reduz
Copy link
Member

@reduz reduz commented Jul 3, 2020

closes #39235

@Calinou Calinou added this to the 4.0 milestone Jul 3, 2020
@bruvzg
Copy link
Member

bruvzg commented Jul 3, 2020

closes #39235

All font issues from the #39235 seems to be fixed.

Editor icon issues are not (probably unrelated to theme):

File dialog icons are missing in the following dialogs:
- All file dialogs opened from "Export"
- All file dialogs opened from "Inspector"

Screenshot 2020-07-04 at 01 59 42

@akien-mga akien-mga mentioned this pull request Jul 3, 2020
Closed
@txj-mssl
Copy link

txj-mssl commented Jul 3, 2020

good

@reduz
Copy link
Member Author

reduz commented Jul 4, 2020

closes #39235

All font issues from the #39235 seems to be fixed.

Editor icon issues are not (probably unrelated to theme):

Should be fixed now.

@akien-mga akien-mga merged commit a5b061e into godotengine:master Jul 4, 2020
@akien-mga
Copy link
Member

Thanks!

@Anutrix Anutrix mentioned this pull request Jul 8, 2020
Closed
60 tasks
@akien-mga akien-mga mentioned this pull request Oct 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Multiple editor theme propagation errors.
5 participants
@reduz @bruvzg @txj-mssl @akien-mga @Calinou