tonemap.glsl: Ensure color parameter of tonemap_reinhard() is positive #42056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groud
reviewed
Sep 14, 2020
Yetizone
force-pushed
the
negative_lights_behavior
branch
from
e3773a8
to
5610d3b
Compare
akien-mga
reviewed
Sep 15, 2020
Color values can become negative in the case of negative lights which leads to undesired behaviour.
Yetizone
force-pushed
the
negative_lights_behavior
branch
from
7820495
to
e6a860d
Compare
reduz
approved these changes
Oct 19, 2020
|
Thanks! |
|
Thanks for getting this merged ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR opened in response to #41901
The problem here is that there are indeed negative values in the
colorparameter oftonemap_reinhard()The division in the forumla causes the negative signs to cancel out so the
clamp()in the return statement doesn't fix this.The changes here add checks that ensure the color values are positive before applying the formula.
The test scene now looks like this:
This issue also happens in
master. I'll make a separate PR there after this one reaches approval and is merged.