-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shape data to Bullet Area overlap data. #42711
Conversation
Rebased following merge of #43952. |
The code generally looks good, it just needs a rebase then testing again on 3.x. |
Thanks! |
|
Actually no, there's more work needed as the cherry-pick doesn't build properly in |
Currently, Bullet physics Areas'
area_shape_entered
,area_shape_exited
,body_shape_entered
andbody_shape_exited
signals always report 0 for thearea_shape
,body_shape
andself_shape
:godot/modules/bullet/area_bullet.cpp
Lines 105 to 108 in bf37ab5
This PR adds the
area_shape
,body_shape
andself_shape
ids to the signals.It also removes the use of
friend
andgoto
in the collision detection function, and renames variables used so the code is easier to read and understand.Fixes #19290.