Initialize class/struct variables with default values in modules/ #43952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qarmin
requested review from
AndreaCatania,
BastiaanOlij,
neikeq,
vnen and
a team
as code owners
qarmin
force-pushed
the
cppcheck_modules
branch
from
665428f to
51530e2
Compare
Faless
reviewed
Nov 29, 2020
qarmin
force-pushed
the
cppcheck_modules
branch
3 times, most recently
from
31d4ec3 to
4c15f1d
Compare
qarmin
force-pushed
the
cppcheck_modules
branch
from
4c15f1d to
3d580b4
Compare
qarmin
force-pushed
the
cppcheck_modules
branch
from
3d580b4 to
ba8a41b
Compare
bruvzg
reviewed
Feb 1, 2021
bruvzg
reviewed
Feb 1, 2021
bruvzg
reviewed
Feb 1, 2021
qarmin
force-pushed
the
cppcheck_modules
branch
from
ba8a41b to
480df8d
Compare
akien-mga
reviewed
Feb 8, 2021
| @@ -47,7 +47,7 @@ class TextureBasisU : public Texture { | |||
| RID texture; | |||
| Size2 tex_size; | |||
|
|
|||
| uint32_t flags; | |||
| uint32_t flags = FLAGS_DEFAULT; | |||
There was a problem hiding this comment.
Suggested change
| uint32_t flags = FLAGS_DEFAULT; | |
| uint32_t flags = FLAGS_DEFAULT; |
modules/bullet/btRayShape.cpp
Outdated
| @@ -43,7 +43,6 @@ btRayShape::btRayShape(btScalar length) : | |||
| m_shapeAxis(0, 0, 1) { | |||
There was a problem hiding this comment.
This can be moved to the header too.
Comment on lines
417
to
418
|
|
||
| editor = nullptr; |
There was a problem hiding this comment.
Shouldn't this go in the header? And button and library_editor can also be initialized to nullptr to be safe, even if they then get assigned values here.
| k2 = 0.215; | ||
| last_ticks = 0; | ||
| }; | ||
| MobileVRInterface::MobileVRInterface(){}; |
There was a problem hiding this comment.
Suggested change
| MobileVRInterface::MobileVRInterface(){}; | |
| MobileVRInterface::MobileVRInterface() {} |
| MobileVRInterface::MobileVRInterface() { | ||
| initialized = false; | ||
|
|
||
| // Just set some defaults for these. At some point we need to look at adding a lookup table for common device + headset combos and/or support reading cardboard QR codes |
There was a problem hiding this comment.
Would be good to port this comment to the header too.
| @@ -41,11 +41,11 @@ class AudioStreamOGGVorbis; | |||
| class AudioStreamPlaybackOGGVorbis : public AudioStreamPlaybackResampled { | |||
There was a problem hiding this comment.
You missed AudioStreamOGGVorbis() which has plenty of stuff to move to the header.
modules/websocket/wsl_peer.h
Outdated
| Ref<StreamPeer> conn; | ||
| Ref<StreamPeerTCP> tcp; | ||
| int id; | ||
| int id = 1; | ||
| wslay_event_context_ptr ctx; |
There was a problem hiding this comment.
Suggested change
| wslay_event_context_ptr ctx; | |
| wslay_event_context_ptr ctx = nullptr; |
|
Left a few comments, otherwise should be good to merge, I looked through the whole diff. |
qarmin
force-pushed
the
cppcheck_modules
branch
from
480df8d to
f7209b4
Compare
akien-mga
approved these changes
Feb 8, 2021
|
Thanks! |
This was referenced Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43636
In future it may also allow to run Memory sanitizer without too big error spam