Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Quickfix for misleading editor message when redeclaring variables #43019

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

mateosss
Copy link
Contributor

Solves #42884.
Before:

func f():
    var x
    ...
    var x
    pass <- Redeclaration of x

Now:

func f():
    var x
    ...
    var x <- Redeclaration of x
    pass 

A similar problem is present in master, however there was a rewrite of the parser in there, and this seemed like an easy enough change to be worth doing.

@mateosss mateosss requested a review from vnen as a code owner October 22, 2020 21:46
@Calinou Calinou added this to the 4.0 milestone Oct 22, 2020
@akien-mga akien-mga modified the milestones: 4.0, 3.2 Oct 22, 2020
@akien-mga akien-mga merged commit da9ef89 into godotengine:3.2 Oct 23, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants