GDScript: Fix mishandling of stack pointers #43775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vnen
commented
Nov 22, 2020
•
vnen
commented
- Replace the for loop temporaries by locals. They cause conflicts with the stack when being popped, while locals are properly handled in the scope.
- Change the interface for the codegen so the for loop list doesn't live through the whole block if it's a temporary.
- Keep track of the actual amount of local variables in the stack. Using the size of the map is misleading in cases where multiple cals have the same name (which is allowed when there's no shadowing).
- Added a few debug checks for temporaries, to avoid them being wrongly manipulated in the future. They should not live more than a line of code.
- Rearrange some of compiler code to make sure the temporaries don't live across blocks.
- Replace the for loop temporaries by locals. They cause conflicts with the stack when being popped, while locals are properly handled in the scope. - Change the interface for the codegen so the for loop list doesn't live through the whole block if it's a temporary. - Keep track of the actual amount of local variables in the stack. Using the size of the map is misleading in cases where multiple locals have the same name (which is allowed when there's no shadowing). - Added a few debug checks for temporaries, to avoid them being wrongly manipulated in the future. They should not live more than a line of code. - Rearrange some of compiler code to make sure the temporaries don't live across blocks.
vnen
force-pushed
the
gdscript-fix-stack
branch
from
d90a83d
to
2e528ef
Compare
|
Now this should be good to merge. |
akien-mga
approved these changes
Nov 25, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.