Update Camera 2D to fix and remove some notifications #43993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 30, 2020 19:07
ghost
mentioned this pull request
Chaosus
changed the title
|
Thanks for your first-time contribution - In order to accept your PR - you need to merge all commits together as described here: https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase |
added 4 commits
November 30, 2020 20:39
ghost
requested a review
from 
|
Looks like I have Destroyed this PR. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple pull request will fix : #28492
By removing the if statement that stops the camera from updating using
NOTIFICATION_TRANSFORM_CHANGED.And removing the
NOTIFICATION_INTERNAL_PROCESSas it has no use.As well as
NOTIFICATION_PROCESS