Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new SDL gamecontroller keywords. #45797

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Add support for new SDL gamecontroller keywords. #45797

merged 1 commit into from
Feb 8, 2021

Conversation

madmiraal
Copy link
Contributor

As identified in #45790, SDL has added some new keywords to their game controller mappings. This PR adds support for those keywords.

Note: This breaks compat, because it changes the value of the enum JOY_BUTTON_SDL_MAX from 15 to 21.

@madmiraal madmiraal added this to the 4.0 milestone Feb 7, 2021
@madmiraal madmiraal requested a review from a team as a code owner February 7, 2021 17:50
@madmiraal madmiraal mentioned this pull request Feb 7, 2021
Merged
@akien-mga akien-mga merged commit c31bceb into godotengine:master Feb 8, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Feb 8, 2021
Merged
@madmiraal madmiraal deleted the add-new-sdl-keywords branch February 8, 2021 16:13
@madmiraal madmiraal mentioned this pull request Apr 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
breaks compat bug topic:import
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@madmiraal @akien-mga