Fix missing ImageTexture::create_from_image call in GPUParticles3DEditor::_generate_emission_points #46671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor::_generate_emission_points Images for emission point texture and normals were created, but not transferred to textures. fix godotengine#43643
|
Can you please test it to make sure that you are getting correct results with this change? It looks like in the issue you linked no one confirmed that the current behaviour was broken. So ideally you need to create a test case that shows that:
|
|
I don't know how this feature is meant to be used, but I put together a short video showing a difference. When you compare the two versions, you can also see in the inspector that the generated images remain empty when using current master. |
|
Superseded by #60739. Thanks for the contribution nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my understand, the texture for emission particles is create in this function. Additionally, there is the option to also generate a normal map, enabling the use of direct emission points.
It is likely that the
create_from_imagecall got lost during some refactoring as mentioned in the related issue. While I have not tested this feature, it does not look like dead code to me, and the difference might be hard to notice for very bright, small particles. The code looks more correct to me with this patch.Images for emission point texture and normals were created, but not
transferred to textures.
fix #43643