Add static methods for creating Image and ImageTexture

[KoBeWi]

Implements #23782
Originally I said that it wouldn't be so useful, but then I actually had to use Image/ImageTexture a bit more. Whenever you create ImageTexture, you immediately assign an image. It gets old fast, so having a shorthand is helpful.

I didn't stop here though. Seems like ImageTexture.create_from_image() is used a lot in core, so I replaced all usage by the new static method. Diff numbers say it well how it simplifies the code.

What changed:

• ImageTexture.create_from_image() is now static
  • seems like non-static version of this method is needed in core (it has a few uses), so I added set_image(). It's not exposed
• Added Image.load_from_file(), which creates Image and loads data
  • I didn't replace load(), because sometimes it's necessary get the loading error
    • although I opened a proposal that would allow it

Now it's possible to e.g. assign a dynamically loaded texture in one line:

$Sprite.texture = ImageTexture.create_from_image(Image.load(path))

It saves lots of typing.

[fire]

I use the image and image texture operators a lot too.

[akien-mga]

This looks like another good candidate for a static method (in a follow-up PR).

[akien-mga]

Needs a rebase, otherwise looks great to me.
Hopefully the rebase also fixes the godot-cpp build which seemed to choke on the static method back in May.

[akien-mga]

Hopefully the rebase also fixes the godot-cpp build which seemed to choke on the static method back in May.

Seems not. CC @godotengine/gdextension

/home/runner/work/godot/godot/godot-cpp/gen/src/classes/image_texture.cpp: In static member function 'static godot::Ref<godot::ImageTexture> godot::ImageTexture::create_from_image(const godot::Ref<godot::Image>&)':
/home/runner/work/godot/godot/godot-cpp/gen/src/classes/image_texture.cpp:46:116: error: '_nullptr' was not declared in this scope; did you mean 'nullptr_t'?
   46 |  return Ref<ImageTexture>::___internal_constructor(internal::_call_native_mb_ret_obj<ImageTexture>(___method_bind, _nullptr, image->_owner));
      |                                                                                                                    ^~~~~~~~
      |                                                                                                                    nullptr_t

[bruvzg]

I can't test it right now, but it's likely caused by a typo on this line:

binding_generator.py#L1155

-method_call += f"return Ref<{return_type}>::___internal_constructor(internal::_call_native_mb_ret_obj<{return_type}>(___method_bind, _nullptr"
+method_call += f"return Ref<{return_type}>::___internal_constructor(internal::_call_native_mb_ret_obj<{return_type}>(___method_bind, nullptr"

[akien-mga]

I can't test it right now, but it's likely caused by a typo on this line:

binding_generator.py#L1155

-method_call += f"return Ref<{return_type}>::___internal_constructor(internal::_call_native_mb_ret_obj<{return_type}>(___method_bind, _nullptr"
+method_call += f"return Ref<{return_type}>::___internal_constructor(internal::_call_native_mb_ret_obj<{return_type}>(___method_bind, nullptr"

That looked like a copy paste mistake from the _owner on the next line.

I pushed the fix: godotengine/godot-cpp@bffedfe

[akien-mga]

Thanks!

[RandomShaper]

@KoBeWi, may you perhaps make Image.create() and Image.create_from_data() static too?