Improve command line --print-fps display
#47735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.x
akien-mga
reviewed
Apr 9, 2021
- Display the frame time in addition to FPS.
- Frame time is a more objective measurement in comparison to FPS,
but FPS is more familiar to people less acquainted with profiling.
- Rename "Game" to "Project" for the project FPS printing line.
Calinou
force-pushed
the
improve-cli-print-fps-display
branch
from
871ec59 to
157d8e4
Compare
akien-mga
approved these changes
Apr 9, 2021
|
Cherry-picked for 3.3. |
akien-mga
removed
the
cherrypick:3.x
aaronfranke
reviewed
Apr 14, 2021
Comment on lines
+2540
to
+2543
| print_line(vformat("Editor FPS: %d (%s mspf)", frames, rtos(1000.0 / frames).pad_decimals(1))); | ||
| } | ||
| } else if (GLOBAL_GET("debug/settings/stdout/print_fps") || print_fps) { | ||
| print_line("Game FPS: " + itos(frames)); | ||
| print_line(vformat("Project FPS: %d (%s mspf)", frames, rtos(1000.0 / frames).pad_decimals(1))); |
There was a problem hiding this comment.
Wrote this on Twitter, but I'll post here too: I suggest s/mspf/ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #47733.
I've also experimented with printing the project FPS with leading indentation to distinguish it from editor FPS when the output is intertwined, but I decided not to include it in this PR. (We can't print both on the same line because they're printed from separate processes at a separate time.)
Here's what it looked like (disregard the incorrect mspf rounding, which I fixed in this PR):