Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ImmediateGeometry #50014

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Deprecate ImmediateGeometry #50014

merged 1 commit into from
Jun 30, 2021

Conversation

reduz
Copy link
Member

@reduz reduz commented Jun 30, 2021

  • Removed entirely from RenderingServer.
  • Replaced by ImmediateMesh resource.
  • ImmediateMesh replaces ImmediateGeometry, but could use more optimization in the future.
  • Sprite3D and AnimatedSprite3D work again, ported from Godot 3.x (though a lot of work was needed to adapt them to Godot 4).
  • RootMotionView works again.
  • Polygon3D editor works again.

image
image
image

@reduz reduz requested review from a team as code owners June 30, 2021 02:01
@reduz reduz force-pushed the remove-immediate branch 2 times, most recently from 0738fe8 to cc0a2a2 Compare June 30, 2021 02:21
@Chaosus Chaosus added this to the 4.0 milestone Jun 30, 2021
JFonS
JFonS reviewed Jun 30, 2021
View reviewed changes
Copy link
Contributor

@JFonS JFonS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good from an overall review. Just noticed some code-style regressions and a possible function rename.

scene/resources/material.cpp Outdated Show resolved Hide resolved
scene/3d/sprite_3d.cpp Outdated Show resolved Hide resolved
clayjohn
clayjohn reviewed Jun 30, 2021
View reviewed changes
scene/3d/sprite_3d.h Outdated Show resolved Hide resolved
@reduz reduz force-pushed the remove-immediate branch from cc0a2a2 to 29a9b4b Compare June 30, 2021 17:00
JFonS
JFonS reviewed Jun 30, 2021
View reviewed changes
scene/3d/sprite_3d.cpp Outdated Show resolved Hide resolved
@reduz
Deprecate ImmediateGeometry
85cf99f 
* Removed entirely from RenderingServer.
* Replaced by ImmediateMesh resource.
* ImmediateMesh replaces ImmediateGeometry, but could use more optimization in the future.
* Sprite3D and AnimatedSprite3D work again, ported from Godot 3.x (though a lot of work was needed to adapt them to Godot 4).
* RootMotionView works again.
* Polygon3D editor works again.
@reduz reduz force-pushed the remove-immediate branch from 29a9b4b to 85cf99f Compare June 30, 2021 17:14
@reduz
Copy link
Member Author

reduz commented Jun 30, 2021

🥳

@akien-mga akien-mga merged commit 270f9d4 into godotengine:master Jun 30, 2021
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab mentioned this pull request Jul 1, 2021
Closed
This was referenced Jul 1, 2021
Closed
Closed
Closed
Closed
@MrJoshBowman
Copy link

MrJoshBowman commented Jul 1, 2021 •
edited
Loading

@reduz I'm trying to test this but can't seem to be able to attach a script as it says "Script inherits from native type 'ImmediateMesh', so it can't be instantiated in object of type 'Node'.

I understand that it's the wrong Node type, but I can't find what Node it should actually be in the 'Change Node Type' list.

@Calinou
Copy link
Member

Calinou commented Jul 2, 2021 •
edited
Loading

I'm trying to test this but can't seem to be able to attach a script as it says "Script inherits from native type 'ImmediateMesh', so it can't be instantiated in object of type 'Node'.

ImmediateMesh is a resource (like ArrayMesh, BoxMesh, …), not a node. Resource doesn't inherit from Node.

@Calinou Calinou mentioned this pull request Nov 3, 2021
Closed
@Calinou Calinou mentioned this pull request Dec 15, 2021
Merged
@Watunder Watunder mentioned this pull request Feb 16, 2022
Open
4 tasks
@Calinou Calinou mentioned this pull request Jun 8, 2022
Closed
@YuriSizov YuriSizov mentioned this pull request Jul 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn left review comments

@JFonS JFonS JFonS approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:rendering topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@reduz @akien-mga @MrJoshBowman @Calinou @JFonS @clayjohn @Chaosus