[3.x] SCons: Refactor module defines into a generated header, cleanup #50466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already had `MODULE_*_ENABLED` defines but only in the modules environment, and a few custom `*_ENABLED` defines in the main env when we needed the information in core. Now this is defined in a single header which can be included in the files that need this information. (cherry picked from commit b7297fb)
- Fix build with gdscript module disabled. Fixes godotengine#31011. - Remove unused `gdscript` compile option. - Fix build with regex module disabled. - Fix ImageLoaderSVG to forward declare thirdparty structs. (cherry picked from commit f3726ee)
Sometimes scons doesn't detects that a new module is being added. This commit fix it. (cherry picked from commit b667e72)
akien-mga
changed the title
Xrayez
added a commit
to goostengine/goost
that referenced
this pull request
Jul 15, 2021
Tests without svg module enabled were failing due to godotengine/godot#50466.
Xrayez
added a commit
to goostengine/goost
that referenced
this pull request
Jul 15, 2021
Tests without svg module enabled were failing due to godotengine/godot#50466.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #35963 for 3.4+. Initially I hadn't planned to backport this but since the
3.2branch turned into a long-lived3.xdevelopment branch, it becomes relevant to backport.