Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 2D editor zoom logic (3.x) #50490

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 15, 2021

3.x version of #48252.

  • Add 1-5 shortcuts to zoom between 100% and 1600% quickly (similar to GIMP).
  • When holding down Alt, go through integer zoom values if above 100% or fractional zoom values with integer denominators if below 100% (50%, ~33.3%, 25%, …).

I tested this PR on 3.x and everything works as expected with the editor scale set to 150%.

- Add 1-5 shortcuts to zoom between 100% and 1600% quickly
  (similar to GIMP).
- When holding down Alt, go through integer zoom values if above 100%
  or fractional zoom values with integer denominators if below 100%
  (50%, ~33.3%, 25%, …).
@Calinou Calinou changed the title Improve 2D editor zoom logic Improve 2D editor zoom logic (3.x) Jul 15, 2021
@Calinou Calinou added this to the 3.4 milestone Jul 15, 2021
Copy link
Contributor

@AaronRecord AaronRecord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, everything seems to work fine.

editor/plugins/canvas_item_editor_plugin.cpp Show resolved Hide resolved
@akien-mga akien-mga merged commit 08d5172 into godotengine:3.x Jul 15, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants