Fix macOS fullscreen incorrect mouse position #51718
Conversation
In relation to #40061. It seems that the issue is when the window get fullscreen, it doesn't change the window size like when it is maximized or scale up and down. So the change i made was forcing the resize event function, when getting in to or out from fullscreen mode.
akien-mga
added
the
cherrypick:3.x
platform/osx/display_server_osx.mm
Outdated
| @@ -190,6 +190,8 @@ - (void)windowDidEnterFullScreen:(NSNotification *)notification { | |||
|
|
|||
| [wd.window_object setContentMinSize:NSMakeSize(0, 0)]; | |||
| [wd.window_object setContentMaxSize:NSMakeSize(FLT_MAX, FLT_MAX)]; | |||
| //Force window resize event | |||
There was a problem hiding this comment.
Nitpick, but we usually style our comments like this:
| //Force window resize event | |
| // Force window resize event. |
Changes the comments to fit with godot's styling.
|
Changed the comments to fit with the style you requested. |
|
Thanks for the fix! Can you squash your comment fixup commit into the first one? Then this should be good to go. |
|
I am sorry but I am new to using git and I think can't do that anymore. I thought the PR got approved so i had remove the fork/branch from account and now I can't figure out how to restore/get the pr branch back. If it isn't possible to do from your end, I could try to redo it with a new PR. |
So, before doing anything, make sure you make a backup of your changes. :)
If you need a more detailed tutorial, searching for the above should help. |
akien-mga
removed
the
cherrypick:3.x
In relation to #40061.
This PR is fixing the incorrect mouse position in fullscreen mode which result UI click registered below expect point.
From my testing, it seems like the issue is that when the window getting into or out fullscreen mode, it wouldn't call the resize event to get correct sizing and scale.
I also notice that when i fullscreen and changing resolution of the display, it will call resize event, and the UI will work as it should. but when getting out from fullscreen mode, it will get back to the same issue, now in window mode.
So my PR is adding a call to resize event when changing to/from fullscreen mode.