LinkButton's text now is automatically translated in 3.x #52138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeldhamDev
approved these changes
Aug 26, 2021
|
What about the master branch fix? The PR wasn't merged there. |
|
@KoBeWi Aren't we discussing to flat out remove |
|
It's not like it's decided already. The changes would be almost the same, so the PR could've been opened for master and then cherry-picked. But well, now that it's merged, master fix can wait. |
|
Cherry-picked for 3.3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #52120
Contributors: @Lucas3H
Bugsquad edit:
3.xversion of #52145.