Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkButton's text now is automatically translated #52145

Merged

Conversation

LeaoLuciano
Copy link
Contributor

@LeaoLuciano LeaoLuciano commented Aug 27, 2021

Fix #52120
Contributors: @Lucas3H

Bugsquad edit: master version of #52138.

@LeaoLuciano LeaoLuciano requested a review from a team as a code owner August 27, 2021 00:51
@YeldhamDev YeldhamDev added this to the 4.0 milestone Aug 27, 2021
scene/gui/link_button.cpp Outdated Show resolved Hide resolved
@YeldhamDev
Copy link
Member

@LeaoLuciano LeaoLuciano force-pushed the linkbutton-translation-4.0 branch from 075d67f to ba30a3c Compare August 27, 2021 01:28
@YeldhamDev
Copy link
Member

The "in 4.0" in the commit message should be dropped.

@LeaoLuciano LeaoLuciano changed the title LinkButton's text now is automatically translated in 4.0 LinkButton's text now is automatically translated Aug 27, 2021
@YeldhamDev
Copy link
Member

YeldhamDev commented Aug 27, 2021

@LeaoLuciano I meant the commit's message, not the PR's title. 😉
Just do git commit --amend, and edit that part out.

@LeaoLuciano LeaoLuciano force-pushed the linkbutton-translation-4.0 branch from ba30a3c to c50c5b9 Compare August 27, 2021 23:17
@mhilbrunner mhilbrunner merged commit 3f6a01e into godotengine:master Sep 7, 2021
@LeaoLuciano LeaoLuciano deleted the linkbutton-translation-4.0 branch September 7, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinkButton's text is not automatically translated (unlike Button)
4 participants