gltf export: Fix export of skeletons and skins. #53114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
reviewed
Sep 27, 2021
|
Some minor problems with variable shadowing and documentation has been modified causing CICD to break. |
|
Exporting blend shapes as not reset to default causes the face blendshapes to explode. |
lyuma
force-pushed
the
export_skin_fixes
branch
4 times, most recently
from
09c403e to
1f3fe06
Compare
|
I have made some additional fixes to blendshapes. They should no longer have such glitches, hopefully. This should now be in a mergable state. |
Create GLTFSkeleton at the same time we create GLTFNode objects. Create GLTFSkin at the same time we export MeshInstance3D Fixes export of blend shape arrays for meshes with multiple surfaces. Fixes array indexing issues in export of glTF morph target animations. Converts BoneAttachment3D nodes during normal node creation: this avoids special cases during mesh export, and especially exporting skeletons or meshes which are children of BoneAttachment3D. Co-authored-by: K. S. Ernest (iFire) Lee <ernest.lee@chibifire.com>
lyuma
force-pushed
the
export_skin_fixes
branch
from
1f3fe06 to
5ffda27
Compare
fire
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Looks good to me. Passes all the CICD tests.
- Blend shapes export and https://github.com/lyuma/godot-tests/tree/add_glb worked.
- Passes my double fox test. Which is a scene with two fox.glbs instanced.
|
Thanks! |
This was referenced Sep 29, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @fire
Create GLTFSkeleton at the same time we create GLTFNode objects.
Create GLTFSkin at the same time we export MeshInstance3D
Also, convert BoneAttachment3D nodes during normal node creation.
This avoids needing special cases during mesh export, and especially exporting skeletons or meshes which are children of BoneAttachment3D.
Should address some of issue #50020. I have not verified the fix, but the old code which dealt with Skeleton or Skin export was very broken so this should be a starting point for future GLTF fixes related to animated or skinned meshes.
This is still in draft state because some of my meshes with blend shapes (but not all of them) fail to load in Blender
Blender error "index 990 is out of bounds for axis 0 with size 990"
Other test cases include the reproduction case I call "Party Hat" since it has a skinned "Party Hat" with springbones attached to a BoneAttachment3D onto the Head bone of a character's Skeleton3D. It seemed to previously reproduce interesting issues on export.
There are a few other glTF files in my collection of cursed glTF models which I still need to test re-exporting, containing duplicate skins, nested skeletons (including cases where a mesh is its own bone), and so on.