Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control: Rename Input group that confuses GDScript completion #54241

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Control: Rename Input group that confuses GDScript completion #54241

merged 1 commit into from
Oct 25, 2021

Conversation

akien-mga
Copy link
Member

Fixes #47926.

We should still investigate and fix the GDScript completion bug, as it could happen again or with any other group that matches a singleton (or possibly a class for static methods?). I'll open an issue.

@akien-mga akien-mga added this to the 3.4 milestone Oct 25, 2021
@akien-mga akien-mga requested a review from a team as a code owner October 25, 2021 20:09
@akien-mga akien-mga mentioned this pull request Oct 25, 2021
Closed
@akien-mga
Copy link
Member Author

I opened #54243 to keep track of the GDScript issue. This Control group was not the only occurrence but it's the most problematic one, as seen in #47926 and especially #53777.

@akien-mga akien-mga merged commit 221beb8 into godotengine:3.x Oct 25, 2021
@akien-mga akien-mga deleted the 3.x-control-rename-input-group branch October 25, 2021 20:24
@akien-mga akien-mga mentioned this pull request Oct 25, 2021
Closed
@YuriSizov YuriSizov mentioned this pull request Oct 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug topic:editor topic:gdscript topic:gui
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@akien-mga @YuriSizov