Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore property groups and categories in GDScript code completion #54272

Merged

Conversation

YuriSizov
Copy link
Contributor

@YuriSizov YuriSizov commented Oct 26, 2021

Fixes #54243. In master any property with slashes in its name is also ignored, but I don't think it can collide with identifiers anyway, so I decided not to add such a check.

Edit: As a result, reverts #54241.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Should we also revert #54241 since it's no longer needed?

@YuriSizov YuriSizov force-pushed the gdscript-ignore-groups-completion-3.x branch from 1a826af to b3fc278 Compare October 26, 2021 17:02
@YuriSizov YuriSizov requested a review from a team as a code owner October 26, 2021 17:02
@YuriSizov
Copy link
Contributor Author

Done 🙂

@akien-mga akien-mga merged commit 5d0ec17 into godotengine:3.x Oct 26, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants