Make default/project theme wait for modules before initializing #55483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54752. Fixes #55008.
I'm not sure if it's okay to add a new method to
register_scene_types.h/cpp, but only other option I see immediately is moving this code tomain.cpp, like so many other things. But that sounds way worse (it's crowded as is). As such, I've decided that the best approach is to keep the code in the same file.The problem is that theme needs some modules to be loaded before it can attempt to be loaded itself, at least this is true for custom themes. But I've moved all related code to keep it all together (it shouldn't affect anything else, other than fix the issue at hand).