Use get_cursor_shape for identifying the cursor shape in CanvasItemEditor #59081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
force-pushed
the
fix-cursorshape-canvasitemeditor
branch
from
e7e3fe5
to
59730bf
Compare
Sauermann
force-pushed
the
fix-cursorshape-canvasitemeditor
branch
from
59730bf
to
dd35934
Compare
…itor get_cursor_shape() is used in cases where a Control displays different cursors in different areas. There is no need to set the default cursor shape on every mouse move event.
Sauermann
force-pushed
the
fix-cursorshape-canvasitemeditor
branch
from
dd35934
to
69fca92
Compare
|
I have verified, that this PR fixes the bug #70789 |
EricEzaM
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Changes seem sound, although I am not super familiar with this code. I only know what I learned when investigating to make #71856.
As long as all the cursor updates are still happening for the respective interactions, it should be fine.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_cursor_shape() is used in cases where a Control displays different cursors in different areas.
There is no need to set the default cursor shape on every mouse move event.
resolve #70789
Was part of the reason for #58960.
As far as I can tell, this is the last place in the source code, where
set_default_cursor_shape()is used duringInputEventMouseMove.Updated 2022-11-03: Fix merge conflict