Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only switch to node when not dragging it #61162

Merged
merged 1 commit into from
May 23, 2022

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented May 18, 2022

Normally when you click node in the scene tree, the inspector will switch immediately. I changed it so that it only switches when you release the mouse button, but only if you didn't start dragging the nodes.
Also removed a hack that forcefully switched to script editor when drag started (it was quite brilliant though. I just repurposed its code :v)
Also removed the Alt hack added in #55761

Closes #39539
Fixes #33704
Supersedes #40438

godot.windows.tools.64_5MB1yoyrhN.mp4

@KoBeWi KoBeWi added enhancement topic:editor usability cherrypick:3.x Considered for cherry-picking into a future 3.x release labels May 18, 2022
@KoBeWi KoBeWi added this to the 4.0 milestone May 18, 2022
@KoBeWi KoBeWi requested a review from a team as a code owner May 18, 2022 17:24
@KoBeWi KoBeWi marked this pull request as draft May 18, 2022 18:08
@KoBeWi KoBeWi marked this pull request as ready for review May 18, 2022 21:25
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The solution is quite different to #40438, would be good to see if there are some changes in that PR worth doing anyway.

@akien-mga akien-mga merged commit 3c9cc79 into godotengine:master May 23, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants