Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix FreeType crashing in GCC + LTO builds. #61803

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 8, 2022

Seems like GCC LTO is not playing nice with setjmp/longjmp and removing a bunch of code, this PR adds assign to the dummy volatile variable to prevent optimization.

Fixes #61499

thirdparty/README.md Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

I assume this might be needed in master too.

@bruvzg
Copy link
Member Author

bruvzg commented Jun 8, 2022

I assume this might be needed in master too.

Probably yes.

@akien-mga akien-mga changed the title Fix FreeType crashing in GCC + LTO builds. [3.x] Fix FreeType crashing in GCC + LTO builds. Jun 8, 2022
@akien-mga akien-mga merged commit ab167db into godotengine:3.x Jun 8, 2022
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the ft_lto_build branch June 8, 2022 11:07
@EzraT
Copy link

EzraT commented Jun 8, 2022

Thank you!

@apodtele
Copy link

apodtele commented Jun 9, 2022

What this work?

   gray_convert_glyph_inner( RAS_ARG,
                             int  continued )
   {
-    int  error;
+    volatile int  error;


     if ( ft_setjmp( ras.jump_buffer ) == 0 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants