Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FreeType crashing in GCC + LTO builds. #61805

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Fix FreeType crashing in GCC + LTO builds. #61805

merged 1 commit into from
Jun 8, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 8, 2022

master version of #61803

@bruvzg bruvzg added this to the 4.0 milestone Jun 8, 2022
@bruvzg bruvzg requested a review from a team as a code owner June 8, 2022 11:00
@akien-mga akien-mga merged commit b250d5d into godotengine:master Jun 8, 2022
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the ft_lto_4 branch June 8, 2022 12:55
@Calinou
Copy link
Member

Calinou commented Jun 8, 2022 •
edited
Loading

For Linux packagers, it might be worth discouraging the use of distribution-provided FreeType until this patch makes its way to upstream FreeType.

@akien-mga
Copy link
Member

Well distros either don't use LTO, or if they do they might get crashes in other applications using FreeType so they'd notice it. Either way, it only affected Windows 11 apparently.

@bruvzg bruvzg mentioned this pull request Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash platform:windows topic:thirdparty
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @akien-mga @Calinou