Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Workaround clang-format 14 bug with Inline oneliner functions #63868

Merged

Conversation

akien-mga
Copy link
Member

We use 'All' which is the default in the base LLVM style.

That's not the style we want but it works around the upstream
regression until clang-format 15.0 is released and widely used:
llvm/llvm-project#54901

Now clang-format 14 should be usable without issue.

@akien-mga akien-mga added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:codestyle labels Aug 3, 2022
@akien-mga akien-mga added this to the 4.0 milestone Aug 3, 2022
@akien-mga akien-mga requested a review from a team as a code owner August 3, 2022 10:13
We use 'All' which is the default in the base LLVM style.

That's not the style we want but it works around the upstream
regression until clang-format 15.0 is released and widely used:
llvm/llvm-project#54901
@akien-mga akien-mga force-pushed the clang-format-workaround-llvm-54901 branch from 76021c9 to 11ec709 Compare August 3, 2022 10:20
@akien-mga akien-mga merged commit 51f0287 into godotengine:master Aug 3, 2022
@akien-mga akien-mga deleted the clang-format-workaround-llvm-54901 branch August 3, 2022 13:04
@akien-mga
Copy link
Member Author

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant