Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-format incorrectly expands short method to be multiple lines in presence of macros #54901

Closed
aeubanks opened this issue Apr 13, 2022 · 3 comments
Closed

clang-format incorrectly expands short method to be multiple lines in presence of macros #54901

aeubanks opened this issue Apr 13, 2022 · 3 comments
Labels
clang-format

Comments

@aeubanks
Copy link
Contributor 

$ cat .clang-format
AllowShortFunctionsOnASingleLine: Inline
$ cat a.h
struct A {
#ifdef A
  void f() { a(); }
#endif
};
$ clang-format
struct A {
#ifdef A
  void f() {
    a();
  }
#endif
};
@llvmbot
Copy link
Member

llvmbot commented Apr 13, 2022

@llvm/issue-subscribers-clang-format

@aeubanks
Copy link
Contributor Author

Regressed by https://reviews.llvm.org/D117142

@aeubanks
Copy link
Contributor Author

Potential fix: https://reviews.llvm.org/D123737

@mkurdej mkurdej added the awaiting-review Has pending Phabricator review label Apr 14, 2022
@owenca owenca mentioned this issue Apr 14, 2022
Closed
@github-actions github-actions bot removed the awaiting-review Has pending Phabricator review label Apr 14, 2022
This was referenced Apr 18, 2022
Merged
Merged
@akien-mga akien-mga mentioned this issue May 5, 2022
Closed
This was referenced Jun 10, 2022
Closed
Merged
Merged
@mkurdej mkurdej mentioned this issue Jul 7, 2022
Closed
@akien-mga akien-mga mentioned this issue Jul 16, 2022
Merged
@akien-mga akien-mga mentioned this issue Aug 3, 2022
Merged
akien-mga added a commit to akien-mga/godot that referenced this issue Aug 3, 2022
@akien-mga
Style: Workaround clang-format 14 bug with Inline oneliner functions
11ec709 
We use 'All' which is the default in the base LLVM style.

That's not the style we want but it works around the upstream
regression until clang-format 15.0 is released and widely used:
llvm/llvm-project#54901
akien-mga added a commit to godotengine/godot that referenced this issue Aug 3, 2022
@akien-mga
Style: Workaround clang-format 14 bug with Inline oneliner functions
ecac887 
We use 'All' which is the default in the base LLVM style.

That's not the style we want but it works around the upstream
regression until clang-format 15.0 is released and widely used:
llvm/llvm-project#54901

(cherry picked from commit 11ec709)
@boldbyteboss boldbyteboss mentioned this issue Aug 4, 2022
Closed
mem-frob pushed a commit to draperlaboratory/hope-llvm-project that referenced this issue Oct 7, 2022
@aeubanks
[clang-format] Skip preprocessor lines when finding the record lbrace
e1f3986 
With D117142, we would now format

```
struct A {
#define A
  void f() { a(); }
#endif
};
```

into

```
struct A {
#ifdef A
  void f() {
    a();
  }
#endif
};
```

because we were looking for the record lbrace without skipping preprocess lines.

Fixes llvm/llvm-project#54901.

Reviewed By: curdeius, owenpan

Differential Revision: https://reviews.llvm.org/D123737
Riordan-DC pushed a commit to Riordan-DC/godot that referenced this issue Jan 24, 2023
@akien-mga
Style: Workaround clang-format 14 bug with Inline oneliner functions
8c33d95 
We use 'All' which is the default in the base LLVM style.

That's not the style we want but it works around the upstream
regression until clang-format 15.0 is released and widely used:
llvm/llvm-project#54901

(cherry picked from commit 11ec709)
@owenca owenca mentioned this issue Oct 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang-format
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkurdej @aeubanks @llvmbot