[Web] Require threads, rtti, allow optimize=speed. #65094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
force-pushed
the
web/4.x_templates_refactor
branch
2 times, most recently
from
41aae1e to
cbd777a
Compare
akien-mga
approved these changes
Aug 30, 2022
Update export names (web[_dlink]_[release|debug].zip). The Build with dynamic linking is broken due to high number of imports in output wasm (likely emscripten regression issue 15487).
Faless
force-pushed
the
web/4.x_templates_refactor
branch
from
cbd777a to
f958f00
Compare
|
Thanks! |
|
Good work! |
|
The singleton and class named |
|
Or just to be |
|
The |
akien-mga
added a commit
to godotengine/godot-build-scripts
that referenced
this pull request
Sep 7, 2022
Follow-up to godotengine/godot#65094. Also reverts LTO change from #62, we found that while it's much slower to link, full LTO still produces smaller binaries and that's quite important for the Web platform.
akien-mga
added a commit
to godotengine/godot-build-scripts
that referenced
this pull request
Sep 7, 2022
Follow-up to godotengine/godot#65094. Also reverts LTO change from #62, we found that while it's much slower to link, full LTO still produces smaller binaries and that's quite important for the Web platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update export names (
web[_dlink]_[release|debug].zip).The Build with dynamic linking is broken due to high number of imports
in output wasm (likely emscripten issue emscripten-core/emscripten#15487).
godotengine/godot-build-scripts#62 will need update.
Closes #65070