Validate physical light units in GI classes. #65807
Conversation
Add checks for physical light units in a few more places to ensure they aren't used when disabled.
| @@ -1001,10 +1001,16 @@ LightmapGI::BakeError LightmapGI::bake(Node *p_from_node, String p_image_data_pa | |||
| lightmapper->add_directional_light(light->get_bake_mode() == Light3D::BAKE_STATIC, -xf.basis.get_column(Vector3::AXIS_Z).normalized(), linear_color, energy, l->get_param(Light3D::PARAM_SIZE), l->get_param(Light3D::PARAM_SHADOW_BLUR)); | |||
| } else if (Object::cast_to<OmniLight3D>(light)) { | |||
| OmniLight3D *l = Object::cast_to<OmniLight3D>(light); | |||
| lightmapper->add_omni_light(light->get_bake_mode() == Light3D::BAKE_STATIC, xf.origin, linear_color, energy * (1.0 / (Math_PI * 4.0)), l->get_param(Light3D::PARAM_RANGE), l->get_param(Light3D::PARAM_ATTENUATION), l->get_param(Light3D::PARAM_SIZE), l->get_param(Light3D::PARAM_SHADOW_BLUR)); | |||
| if (GLOBAL_GET("rendering/lights_and_shadows/use_physical_light_units")) { | |||
There was a problem hiding this comment.
Do I read this change correctly and was physical lighting the default before? Or should there be a calculation applied to energy when physical lighting is turned off?
There was a problem hiding this comment.
There should not be a calculation applied when physical lighting is turned off. I accidently left the unit conversion in when making the original PR. But the unit conversion is only applicable when using physical light units. This bug resulted in OmniLights appearing too dark in baked lighting when PLU is turned off.
|
We're already doing this everywhere but I wonder if there is a better way to access our setting then copying the |
|
Thanks! |
Add checks for physical light units in a few more places to ensure they aren't used when disabled.
Fixes: #65586