Fixed wrong base class when using extends Base.Subclass

[rune-scape]

Fixes #65953

Also prevents a crash on startup when opening this project, which has weird almost cyclic inheritance.
godot-rune-wrong-subclass-base-proj.zip
Edit: no longer prevents the crash on startup

[bitbrain]

inner-classes-refcount-errors.zip

@rune-scape could you try out this project? On current master branch it gives me this error:

as it is unable to detect that ParentClass is a base class of SubClass

[bitbrain]

Just tested it with your change and compared to current master it gives me now just a "Parser error" but still fails. (no console errors/stacktrace whatsoever)

[rune-scape]

Thanks for the input!
I've tested with that last push that both projects work (and would appreciate someone else confirming that),
but this should all really be applied after #65752, and then resolving inner classes of other scripts can be moved into _gdtype_from_datatype, where it belongs.

[bitbrain]

The latest commit of this PR now gives me a different error:

@rune-scape are you saying that once #65752 is merged that your PR should work without any issues in this regard? Otherwise I might write up a different issue after both the PRs are being merged.

[rune-scape]

Ah, yes, I minced my words. That is a separate issue that should (hopefully) be resolved after #65752 is merged AND the fix I mentioned in my last comment is applied.

[bitbrain]

@rune-scape looks like the formatting is failing at the moment:

https://github.com/godotengine/godot/actions/runs/3185280223/jobs/5194668640

[rune-scape]

Ya, but... its messed up, the formatting isn't wrong like it says. I didn't change any of the code its crying about.

[adamscott]

Ya, but... its messed up, the formatting isn't wrong like it says. I didn't change any of the code its crying about.

@rune-scape I suggest you run clang-format -i modules/gdscript/gdscript.cpp.

[rune-scape]

Here's a screenshot of the diff, I have to assume its a bug in the formatter.

[rune-scape]

There also seems to be 1 or 2 more places where extending an inner class is not taken into account.
I now think that extends should be changed in the parser to an identifier/preload and subscript expression because it simplifies everything.
It's mentioned in the analyzer:

godot/modules/gdscript/gdscript_analyzer.cpp

Line 370 in 880a017

// TODO: Extends could use identifier nodes. That way errors can be pointed out properly and it can be used here.

I feel like anything else is just chasing bugs as they pop up.
I'm working on it and figuring out whether or not it needs #65752.

[akien-mga]

Here's a screenshot of the diff, I have to assume its a bug in the formatter.

This is a known bug indeed, the same code is having to use /* clang-format off */ in the Mono module.