Initial InputEvent set of unit tests #68677
Open
+113
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covers all branches of non-virtual functions for all derivatives of the InputEvent class.
…al function calls Cleaned up formatting issues and added class specifiers to hopefully resolve the macOS build issues.
|
Seems to crash: There are also style issues to fix, see the diff (wrong filename in header, and wrong indentation style): https://github.com/godotengine/godot/actions/runs/3467850975/jobs/5793096042 |
IanGaither
force-pushed
the
input-event-unit-tests
branch
3 times, most recently
from
d5049cc to
3957af5
Compare
Removed extra space fixed spacing on multiline macro removed tabs from spacing on multiline macro Update test_input_event.h
IanGaither
force-pushed
the
input-event-unit-tests
branch
from
3957af5 to
18aef3a
Compare
|
You could also add tests for |
|
Note that #79444 (which was opened after this PR) has already added tests for InputEvent with a different, incompatible code structure. It's still possible to add more unit tests to the now-existing file, but you'll need to refactor the code added by your pull request to do so. Feel free to look into doing this if you have time – if you don't, let us know and we can mark this PR as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers all branches of non-virtual functions for all derivatives of the InputEvent class.
I'm not sure how to add the discussion label, but I was hoping to get some feedback on how to approach the rest of the class. Currently I've covered all the non-virtual functions (since it's abstract that required testing all the child classes). I think the rest of the functionality should be covered in tests that target each child directly, but I'm not sure as I've haven't worked with unit tests a ton and especially haven't worked with them in C++ before.
Any feedback would be appreciated!
Tests for class based on suggestions from: #43440 (comment)