Add a test suite to InputEvent #79444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miguel0312
force-pushed
the
TestInputEvent
branch
from
0affd65 to
7212bc0
Compare
Sauermann
reviewed
Jul 14, 2023
Miguel0312
force-pushed
the
TestInputEvent
branch
from
7212bc0 to
4952b39
Compare
Sauermann
reviewed
Jul 17, 2023
|
The content looks good. Now please squash the two commits together. |
Miguel0312
force-pushed
the
TestInputEvent
branch
from
97998a9 to
c2ad5ca
Compare
Sauermann
approved these changes
Jul 17, 2023
YuriSizov
changed the title
YuriSizov
approved these changes
Jul 21, 2023
|
Thanks! And congrats on your first merged Godot PR! |
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the tests to InputEvent and is part of #43440.
Since InputEvent is an abstract class and cannot be instantiated, I used the subclasses relevant to each method as indicated in the docs.
A second version of these tests would consist in tests for each subclass instead of a single test suite for the abstract super class.