Fix Viewport::get_mouse_position for SubViewports #71768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
force-pushed
the
fix-vp-mouse-position
branch
from
b87c0fa
to
b0d31a9
Compare
Sauermann
force-pushed
the
fix-vp-mouse-position
branch
5 times, most recently
from
7493c23
to
3fc5c0e
Compare
|
Is there any potential use case for the exposed Just to be sure, since I'm a bit fuzzy on the details now. |
|
You are right. Currently I can't think of any use-case for |
SubViewports don't have a cached mouse position available. This PR calculates the mouse position from the screen position of the mouse cursor.
Sauermann
force-pushed
the
fix-vp-mouse-position
branch
from
3fc5c0e
to
5312d83
Compare
RandomShaper
approved these changes
Feb 7, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubViewports don't have a cached mouse position available. This PR calculates the mouse position from the screen position of the mouse cursor.
Closes #60390
Closes #72807
supersedes #62274
The
get_screen_transformAPI-change doesn't break compatibility, because the behavior with the default-value stays the same.Updated 2023-01-27: Fix merge conflict
Updated 2023-01-31: Rebase to master after #71972 which made necessary changes to unittests.
Updated 2023-02-01: Fix merge conflict
Updated 2023-02-03: Fix merge conflict