[unittests] Send Mouse events via DisplayServer instead of push_input #71972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2023
Geometror
reviewed
Jan 29, 2023
Sauermann
force-pushed
the
fix-test-ds
branch
from
b3019b2
to
381f4e4
Compare
Currently Unittests simplify mouse-events by just pushing them to Viewports. For dealing with mouse-screen-coordinates (caused by the introduction of multiple native Windows) it becomes necessary to extend the DisplayServer functionality for unittests. This PR introduces DisplayServerMock based on DisplayServerHeadless, which additionally supports basic Mouse-Input handling.
Sauermann
force-pushed
the
fix-test-ds
branch
from
381f4e4
to
7de1b1a
Compare
|
Haven't reviewed yet, but is there any reason why we wouldn't want to implement this mock support directly in DisplayServerHeadless? |
|
I also thought about this but took this safe approach with a new class, because I am not familiar with where |
akien-mga
approved these changes
Jan 31, 2023
|
Thanks! |
This was referenced Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Unittests simplify mouse-events by just pushing them to Viewports. For dealing with mouse-screen-coordinates (caused by the introduction of multiple native Windows) it becomes necessary to extend the DisplayServer functionality for unittests.
This PR introduces
DisplayServerMockbased onDisplayServerHeadless, which additionally supports basic Mouse-Input handling.This functionality is required for:
Updated 2023-01-29: Renamed
DisplayServerTeststoDisplayServerMock.