Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for interpolating skewed Transform2Ds #72287

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Jan 29, 2023

Fixes #64252, supersedes #64418. Also adds a test case. See my comment at the bottom of #64418.

BugSquad Edited:
Fixes #71974

@aaronfranke aaronfranke added this to the 4.0 milestone Jan 29, 2023
@aaronfranke aaronfranke requested review from a team as code owners January 29, 2023 00:40
@TokageItLab
Copy link
Member

I also commented in #64418 (comment), since 3D supports skew, so I suggest that the same fix is needed for Transform3D::interpolate_with as well for consistency.

Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I agree with this fix. It is definitely better than the current broken Transform2D::interpolate_with(). But Transform3D::interpolate_with() still has a problem which discards skew, so it will be needed to be improved later on.

@akien-mga akien-mga merged commit d01ac9c into godotengine:master Jan 29, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants