Fix Animation::subtract_variant
for affine transforms
#79279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform2D::inverse
/Transform3D::inverse
which were used inAnimation::subtract_variant
work only for rotation + translation, don't work for scale, skew, etc.This resulted in e.g.
PropertyTweener
incorrectly calculating the delta for affine transforms:godot/scene/animation/tween.cpp
Line 557 in b8ed596
Fixes #79242.